Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add instructions for changing theme #87

Closed
wants to merge 22 commits into from
Closed

docs: add instructions for changing theme #87

wants to merge 22 commits into from

Conversation

lakshyaag
Copy link
Contributor

@lakshyaag lakshyaag requested a review from a team as a code owner May 2, 2024 03:02
tianjing-li
tianjing-li approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @elaineg can you check this to make sure its in line with what you're looking for?

wujessica
wujessica approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@wujessica wujessica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! Just left some tiny nits, thanks for making these changes!!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lakshyaag
Copy link
Contributor Author

Thanks @wujessica, I've made the suggested changes. Not sure what to do with the merge conflict here.

@lakshyaag lakshyaag requested a review from wujessica May 7, 2024 16:26
@wujessica
Copy link
Contributor

Thanks @wujessica, I've made the suggested changes. Not sure what to do with the merge conflict here.

Ahh I guess we've restructured our README.md, I think this could go under how_to_guides.md? Would you mind moving it into that file and following that format? And adding a link on L13 in the README.md file

@lakshyaag
Copy link
Contributor Author

Thanks @wujessica, I've made the suggested changes. Not sure what to do with the merge conflict here.

Ahh I guess we've restructured our README.md, I think this could go under how_to_guides.md? Would you mind moving it into that file and following that format? And adding a link on L13 in the README.md file

Done!

wujessica
wujessica approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@wujessica wujessica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you so much!!

@lakshyaag
Copy link
Contributor Author

Great, please merge when ready.
@wujessica, any comments on the logo part of #12? I'll try creating a prototype tonight

@wujessica
Copy link
Contributor

Great, please merge when ready. @wujessica, any comments on the logo part of #12? I'll try creating a prototype tonight

That approach makes sense to me, excited to see the prototype :)

@lakshyaag lakshyaag mentioned this pull request May 8, 2024
Closed
@wujessica
Copy link
Contributor

@lakshyaag looks like some of the commits on this PR aren't signed so I can't merge, could you help sign them?

image

@lakshyaag
Copy link
Contributor Author

Hi @wujessica, I just added the GPG key locally. Could you please help me on how I can go back and sign all the commits?

@wujessica
Copy link
Contributor

@lakshyaag you might need to squash and re-commit, it looks like it's your earlier commits that weren't signed (any of the below that don't say Verified)

image

lakshyaag and others added 12 commits May 8, 2024 14:58
@lakshyaag
docs: add instructions for changing theme
a8561f6 
Signed-off-by: Lakshya Agarwal <lakshyajannu@gmail.com>
@lusmoura @lakshyaag
Deployment: add local model deployment option (cohere-ai#77)
78ea3ce 
* Deployment: add local model deployment option

* lint

* add tests

* lint

* fix cohere prompts
@lusmoura @lakshyaag
Docs: add env setup instructions (cohere-ai#88)
359e1c3
@lusmoura @lakshyaag
Cli: add dummy tests (cohere-ai#89)
ef6da4a 
* Cli: add dummy tests

* move cli to backend
@malexw @lakshyaag
backend: Set up next.js to proxy requests to the API (cohere-ai#86)
3e77823 
Set up next.js to proxy requests to the API
@malexw @lakshyaag
tools: Update default NEXT_PUBLIC_API_HOSTNAME for the new api routing (
31d9311 
cohere-ai#94)

* Update default NEXT_PUBLIC_API_HOSTNAME for the new api routing

* Also update NEXT_PUBLIC_API_HOSTNAME in README and .env-template
@lakshyaag @wujessica
Apply suggestions from code review
bc6c688 
Minor formatting

Co-authored-by: Jessica Wu <jessica@cohere.ai>
@tianjing-li @lakshyaag
fix: broken backend URL in cli (cohere-ai#93)
034cbef 
Update main.py

Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>
@dependabot @lakshyaag
build(deps-dev): bump jinja2 from 3.1.3 to 3.1.4 (cohere-ai#105)
0afe494 
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.3...3.1.4)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lusmoura @lakshyaag
Tools: fix citations (cohere-ai#108)
6ce0e5e
@BeatrixCohere @lakshyaag
Update documentation (cohere-ai#107)
404793d 
Update docs
@BeatrixCohere @lakshyaag
Fix link for docs (cohere-ai#110)
d539d6a 
Change
lakshyaag and others added 10 commits May 8, 2024 14:58
@lakshyaag
docs: move into new structure
9358c2c 
Signed-off-by: Lakshya Agarwal <lakshyajannu@gmail.com>
@tianjing-li @lakshyaag
backend: Refactor model deployments folder (cohere-ai#109)
968e2ef 
* Refactor model deployments folder

* lint

* fix imports

* fix imports
@tianjing-li @lakshyaag
Add baseline Architecture to support auth + User sessions + Basic Auth (
110d47b 
cohere-ai#90)

* Auth wip

* Add tests

* working basic auth

* add test coverage: still todo add session tests

* Add session tests

* Add docs

* fix types

* merge alembic

* add secret key fixture

* fix tests
@mauro-schilman @lakshyaag
docs: Update setup.md and makefile instruction to point to the right …
dadce8a 
…path (cohere-ai#114)

* Update setup.md

* Fix make setup
@acanis @tianjing-li @lakshyaag
Frontend: Fix cohere-ai#97, change default python interpreter URL to …
cae4725 
…http://terrarium:8080 (cohere-ai#103)

Fix cohere-ai#97: Change default python interpreter URL to http://terrarium:8080

The previous default http://localhost:8080 didn't work with docker
compose on Mac

Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>
@dependabot @lusmoura @lakshyaag
build(deps-dev): bump tqdm from 4.66.2 to 4.66.3 (cohere-ai#96)
afd3ea9 
Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3.
- [Release notes](https://github.com/tqdm/tqdm/releases)
- [Commits](tqdm/tqdm@v4.66.2...v4.66.3)

---
updated-dependencies:
- dependency-name: tqdm
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luísa Moura <luisa@cohere.com>
@lusmoura @lakshyaag
CLI: install setup and community dependencies (cohere-ai#116)
1840776
@BeatrixCohere @lakshyaag
Fix doc links (cohere-ai#117)
8067b1f 
* Fix links

* Fix links
@lusmoura @lakshyaag
CLI: fix default values (cohere-ai#119)
5bb74d6 
* CLI: fix default values

* fix
@misspia-cohere @lakshyaag
github actions: add build + lint check workflow for coral_web (cohere…
19dd403 
…-ai#81)

* add coral_web workflow

* add path filter

* setup node, pnpm and install deps before running checks

* update node version file path

* update actions paths/directories
@lakshyaag
Copy link
Contributor Author

I think I messed up. Let me re-open this with a clean version.

@lakshyaag lakshyaag closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wujessica wujessica wujessica approved these changes

@tianjing-li tianjing-li tianjing-li approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lakshyaag @wujessica @tianjing-li @lusmoura @malexw @BeatrixCohere @mauro-schilman @acanis @misspia-cohere