Add baseline Architecture to support auth + User sessions + Basic Auth #90
+770
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianjing-li
changed the title
tianjing-li
commented
May 3, 2024
tianjing-li
commented
May 3, 2024
rodrigue-h
reviewed
May 3, 2024
tianjing-li
changed the title
scott-cohere
approved these changes
May 6, 2024
scott-cohere
approved these changes
May 7, 2024
scott-cohere
approved these changes
May 7, 2024
lakshyaag
pushed a commit
to lakshyaag/cohere-toolkit
that referenced
this pull request
May 8, 2024
cohere-ai#90) * Auth wip * Add tests * working basic auth * add test coverage: still todo add session tests * Add session tests * Add docs * fix types * merge alembic * add secret key fixture * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beefy first PR to setup plug & play Auth:
Adds new
authfolder in servicesAdds
BaseAuthenticationStrategyabstract class andBasicAuthentication(email+password) to start with. The base class should be inherited from all Auth strategies, next steps should include adding OAuth strategies.Adds
authroutes, can retrieve session, logout, login, auth (to implement). The /login method should be generic and run for all auth strategiesAdds
SessionMiddlewareto track current user sessionAdds extensive unit testing
Add tests and docs: Please include testing and documentation for your changes
Lint and test: Run
make lintandmake run-tests