RAG Guide: Wrap individually chatbot query run into a helper function #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2024 16:05
… from .env file Nice convenience function, don't need to acecpt if you don't like it ## Test Plan Notebook runs if you define API keys in an .env file
I noticed that this was breaking for when I was running this in Jupyter notebooks. I also noticed we had comments in the notebook saying `# Uncomment for Google Colab to ...` so figured we could do the same here. If you don't like it, no worries
## Test Plan
Before it wasn't working, and we got these errors
```
Error in callback <function set_css at 0x33e33d260> (for pre_run_cell), with arguments args (<ExecutionInfo object at 33e35b110, raw_cell="raw_documents = [
{
"title": "Text Emb.." store_history=True silent=False shell_futures=True cell_id=vscode-notebook-cell:/Users/rossdancraig/Projects/cohere-notebooks/notebooks/guides/RAG_with_Chat_Embed_and_Rerank_via_Pinecone.ipynb#X13sZmlsZQ%3D%3D>,),kwargs {}:
```
```
{
"name": "TypeError",
"message": "set_css() takes 0 positional arguments but 1 was given",
"stack": "---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
TypeError: set_css() takes 0 positional arguments but 1 was given"
}
```
Now it works!
This was referenced Apr 25, 2024
|
Rossdan Craig rossdan@lastmileai.dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This was mainly just a personal preference choice, not a big deal if you don't like it, no worries if you don't want to approve ## Test Plan No functional changes, notebook still works
rossdanlm
changed the title
|
@rossdanlm Thanks for the suggestion! I think at this point I'll not merge but will keep this as reference for any changes later (because we have other notebooks using the same implementation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAG Guide: Wrap individually chatbot query run into a helper function
This was mainly just a personal preference choice, not a big deal if you don't like it, no worries if you don't want to approve
Test Plan
No functional changes, notebook still works
Stack created with Sapling. Best reviewed with ReviewStack.