Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with openjdk 8 #844

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WeichenXu123
Copy link
Contributor

Signed-off-by: Weichen Xu weichen.xu@databricks.com

Build with openjdk 8

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
Copy link
Contributor Author

@jsleight
Can we make mleap CI running against JDK 8 ? Databricks runtime is still using jdk 8 .

@WeichenXu123
Copy link
Contributor Author

Run sbt test with jdk 8 passed on my development ubuntu machine.

@WeichenXu123 WeichenXu123 reopened this Feb 6, 2023
@jsleight
Copy link
Contributor

jsleight commented Feb 6, 2023

The latest tensorflow-java versions are only building for java 11 https://github.com/tensorflow/java/blob/master/README.md#tensorflowjava-version-support

So downgrading to java 8 would prohibit us from upgrading tensorflow.

@WeichenXu123
Copy link
Contributor Author

ok I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants