Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Euler Dy and Eyler Smea Dy samplers #3227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Endebert
Copy link

@Endebert Endebert commented Apr 9, 2024

Taken from https://github.com/Koishi-Star/Euler-Smea-Dyn-Sampler.

Adding them was trivial, so here's the corresponding PR.

@pamparamm
Copy link
Contributor

I think it's a little bit early to add these samplers to the upstream.
There are some possible issues with the original implementation (see Koishi-Star/Euler-Smea-Dyn-Sampler#5 (comment) and Koishi-Star/Euler-Smea-Dyn-Sampler#7 (comment)).
Plus, as implied by NovelAI, SMEA should be applicable to all k_diffusion samplers, not just Euler.

@ananosleep
Copy link

I think it's a little bit early to add these samplers to the upstream. There are some possible issues with the original implementation (see Koishi-Star/Euler-Smea-Dyn-Sampler#5 (comment) and Koishi-Star/Euler-Smea-Dyn-Sampler#7 (comment)). Plus, as implied by NovelAI, SMEA should be applicable to all k_diffusion samplers, not just Euler.

You're right. This is not the original SMEA(since NovelAI had never publish how to), but only a trial, which just want to reproduce similar effect like SMEA Dyn. Now it has some improvement in generating good hands and eyes, but still need further adjustment, so maybe it's not a good idea to merge into ComfyUI so fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants