Cache /object_info #3334
Open
Cache /object_info #3334
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a lot of custom nodes installed, it can take a while to iterate through all of them. This takes page reload from 5s to under 1s on my machine. AFAIK new nodes are never added after startup, so the cache remains valid.
|
If this method is applied, the refresh will not be reflected. |
|
I see I see, hmm. One option would be to create a "quick reload" route and "full refresh" route. The latter would only happen when you press the button, so f5 and new tab would be faster. But many users likely hit f5 to do a full refresh, so it would be an unexpected change in behavior. I don't have another good solution off the top of my head. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a lot of custom nodes installed, it can take a while to iterate through all of them. This takes page reload from 5s to under 1s on my machine.
AFAIK new nodes are never added after startup so the cache remains valid.