-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix msys ORIGINAL_PATH confusion #16269
Fix msys ORIGINAL_PATH confusion #16269
Conversation
Ensure ORIGINAL_PATH is unset, so msys's /etc/profile will use the previous PATH as the future PATH.
Hi @paulharris Could you please have a look to the suggestion in #16268 (comment)? |
Thanks for the prod, I'll give it a test in the next few days
…On Thu, 30 May 2024, 6:55 pm James, ***@***.***> wrote:
Hi @paulharris <https://github.com/paulharris>
Could you please have a look to the suggestion in #16268 (comment)
<#16268 (comment)>?
—
Reply to this email directly, view it on GitHub
<#16269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMSASZPVYN6FLW5ONDULBLZE4AS3AVCNFSM6AAAAABHZPO6IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGI4TMMRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds good, keep me posted @paulharris we plan to branch Conan 2.4 on Monday |
Your suggested alternative patch works for me. |
If you want to update your PR with the change, I think it is fair to get yours merged, you did most of the research, I only suggested as small location change of the place to clean the env-var. |
0b36e4c
to
4c87725
Compare
msys's /etc/profile checks and uses ORIGINAL_PATH as its PATH, instead of the PATH in the environment. We want to avoid this, and use the PATH that conan has prepared. The design is so any msys shell started within an existing msys shell will start with the original environment the first msys started with. This applies when the user runs conan from within a msys terminal, and builds a package that uses an embedded msys environment (eg AutoTools-based packages).
4c87725
to
408b291
Compare
There you go, sorry for force-pushes, weekend-brain. |
Thanks for your contribution! |
Changelog: Omit
Docs: Omit
Ensure ORIGINAL_PATH is unset,
so msys's /etc/profile will use the previous PATH as the future PATH.
Refer to #16268