-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve design of the webapp #1364
base: master
Are you sure you want to change the base?
Conversation
Cooq
commented
Dec 2, 2016
- Moving from a top menu to a sidebar menu
- Redesign viewblocks
- Redesign navigation tabs (subnav class)
- Modification of input tags for dark GTK theme compatibility
@Cooq nice work. Looks good. |
This side menu looks pretty nice to me. It makes the app feel more modern, and I'm a sucker for dark themes. My main concerns are link color (the user link and icons on the bottom left of the menu are totally lost) and some of the styles that may have gotten lost/broken in the transition (see screenshots below). But I think this left-menu concept is worth working on. Let's get some more core team input, too. Old jump/button/feed selector: New jump/button/feed selector: |
Thanks @Cooq! I'd be interested in hearing from more people about the vertical nav versus our current horizontal nav. The horizontal menu doesn't scale well for plugin menus and longer lists of menu items. Wordpress uses a vertical menu and it might be a good change for us to incorporate. Visuals-wise, what was the rationale for the darker theme? I'm not opposed to it but feel like the link color needs to be different (not the blue, which clashes here), or we should consider some tweaked colors. A contrast in background between the nav and content area provides some advantages, but it's a more significant change to our brand palette. I can play around with some alternatives over the next week and show you guys what I come up with. |
I like the theme overall, I agree about the blue links in the dark sidebar. Make them white. |
So this PR is associated with the 2.3.4 milestone, but 2.3.4 is out. Does 2.3.4 include this new design? |
@xd1936 no, this PR has not yet been merged. |
Are conflicts going to be resolved to have these styles? |
@Cooq, I really like what you've done. With a couple minor tweaks I will be ready to merge this. I apologize for the length of time it has taken this PR to get the attention it needs. Would you be able to fix the following?
|
It has been a long time since I have done this. |
I fixed the points 2, 3, 4 but I could not reproduce the 1. |
@Cooq this looks great-- I'll try and get to it soon. Thanks! |
@Cooq the pagination issue (item 1 above) appears when there are a lot of items, and the pagination controls show up. |
Sorry for the delay, I finally fixed the pagination. |
@Cooq There is only one little issue with this PR: Perhaps this is helpful... |
Will this be merged for a new release any time soon? I'm looking at Concerto for a project and want to start with as up-to-date a release as possible. |