Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of the webapp #1364

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Improve design of the webapp #1364

wants to merge 18 commits into from

Conversation

Cooq
Copy link

@Cooq Cooq commented Dec 2, 2016

  • Moving from a top menu to a sidebar menu
  • Redesign viewblocks
  • Redesign navigation tabs (subnav class)
  • Modification of input tags for dark GTK theme compatibility

@bamnet
Copy link
Member

bamnet commented Dec 2, 2016

@brzaik / @khanh - Any feedback?

@mfrederickson
Copy link
Contributor

@Cooq nice work. Looks good.

@augustf
Copy link
Member

augustf commented Dec 4, 2016

For those without a locally branched version:
screen shot 2016-12-03 at 8 49 27 pm

@augustf
Copy link
Member

augustf commented Dec 4, 2016

This side menu looks pretty nice to me. It makes the app feel more modern, and I'm a sucker for dark themes. My main concerns are link color (the user link and icons on the bottom left of the menu are totally lost) and some of the styles that may have gotten lost/broken in the transition (see screenshots below). But I think this left-menu concept is worth working on. Let's get some more core team input, too.

Old jump/button/feed selector:

screen shot 2016-12-03 at 8 59 02 pm

New jump/button/feed selector:

screen shot 2016-12-03 at 8 48 52 pm

@brzaik
Copy link
Member

brzaik commented Dec 4, 2016

Thanks @Cooq!

I'd be interested in hearing from more people about the vertical nav versus our current horizontal nav. The horizontal menu doesn't scale well for plugin menus and longer lists of menu items. Wordpress uses a vertical menu and it might be a good change for us to incorporate.

Visuals-wise, what was the rationale for the darker theme? I'm not opposed to it but feel like the link color needs to be different (not the blue, which clashes here), or we should consider some tweaked colors. A contrast in background between the nav and content area provides some advantages, but it's a more significant change to our brand palette. I can play around with some alternatives over the next week and show you guys what I come up with.

@augustf augustf modified the milestone: 2.3.4 Dec 5, 2016
@taras-yorku
Copy link

I like the theme overall, I agree about the blue links in the dark sidebar. Make them white.

@leoherzog
Copy link
Contributor

So this PR is associated with the 2.3.4 milestone, but 2.3.4 is out. Does 2.3.4 include this new design?

@mfrederickson
Copy link
Contributor

@xd1936 no, this PR has not yet been merged.

@mfrederickson mfrederickson removed this from the 2.3.4 milestone Mar 15, 2018
@Suriv
Copy link

Suriv commented Oct 18, 2019

Are conflicts going to be resolved to have these styles?

@mfrederickson
Copy link
Contributor

@Cooq, I really like what you've done. With a couple minor tweaks I will be ready to merge this. I apologize for the length of time it has taken this PR to get the attention it needs. Would you be able to fix the following?

  1. The User's page has an odd vertical bar (from the pagination for the content list down below).
    image

  2. The slider has no outline unless you hover over it.
    image

  3. When the menu is collapsed, you can still click on the items you cannot see. How about showing an icon for each menu option when it is collapsed?
    image

  4. Can you make the name a little smaller and the menu-bottom gray unless hovered and then grayLight like you did with the other menu options? Or something like that?
    image

@Cooq
Copy link
Author

Cooq commented Nov 6, 2019

It has been a long time since I have done this.
I will try to correct the bugs you've mentioned and push it

@Cooq
Copy link
Author

Cooq commented Nov 26, 2019

I fixed the points 2, 3, 4 but I could not reproduce the 1.

@Cooq
Copy link
Author

Cooq commented Nov 26, 2019

Screenshot_2019-11-26_14-42-37
Screenshot_2019-11-26_14-48-18

@mfrederickson
Copy link
Contributor

@Cooq this looks great-- I'll try and get to it soon. Thanks!

@mfrederickson
Copy link
Contributor

@Cooq the pagination issue (item 1 above) appears when there are a lot of items, and the pagination controls show up.

@Cooq
Copy link
Author

Cooq commented Jan 20, 2020

Sorry for the delay, I finally fixed the pagination.

@pandel
Copy link

pandel commented Jan 8, 2021

@Cooq
Wonderful addition! Really love the new look.

There is only one little issue with this PR:
In your Gemfile.lock the BUNDLED WITH is set to 2.0.2. This leads to a conflict when using the Dockerfile to build the image. I just reverted to 1.17.3 as in the original Gemfile.lock and my build was successful.

Perhaps this is helpful...

@evansharp
Copy link

Will this be merged for a new release any time soon? I'm looking at Concerto for a project and want to start with as up-to-date a release as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants