update to turbolinks v5 - affects multiple repos

[mfrederickson]

This may also require concerto plugins to be updated so they don't break.

[augustf]

@mfrederickson Is this change backward compatible?

[mfrederickson]

No, I don't believe so-- none of the older plugins will work with it-- that's why I had to change them as well.

[augustf]

@mfrederickson Well what I meant is that if I update and push the plugins, and folks with older Concerto's install them, will it break?

[mfrederickson]

Yes it will break

…

On Mar 3, 2017, at 5:23 PM, August ***@***.***> wrote: @mfrederickson Well what I meant is that if I update and push the plugins, and folks with older Concerto's install them, will it break? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[augustf]

@mfrederickson Then we'll probably need some mechanism to handle updates like this. Either include logic in the code change itself to avoid breakage or have a check for version number or something before installing it. We don't want to break the installations of folks who unwittingly upgrade a plugin.

[mfrederickson]

I will look into making the plugins backwards compatible

…

On Sat, Mar 4, 2017 at 10:07 AM, August ***@***.***> wrote: @mfrederickson <https://github.com/mfrederickson> Then we'll probably need some mechanism to handle updates like this. Either include logic in the code change itself to avoid breakage or have a check for version number or something before installing it. We don't want to break the installations of folks who unwittingly upgrade a plugin. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1387 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAc4TfvMtmr-L4-NxPCt2h12-y5kvHHAks5ribZhgaJpZM4MPHsx> .

[mfrederickson]

@augustf I am unable to detect which version of turbolinks is running. Do you have any ideas how we can make this backwards compatible?

[augustf]

@mfrederickson My main thought would be to try to check by which method(s) it responds to. That is, if the new Turbolinks has new_turbolinks_method(), your script can test to see if that's true. Alternatively, we could expose the versions of installed Rubygems via an API of some sort. Failing all of that, we may need to find a way to restrict plugin upgrades in the panel so users don't break their installs.

[augustf]

@mfrederickson Also, is a Turbolinks patch required for concerto-weather? I notice it alone of the addons didn't get one...

[mfrederickson]

@augustf yes, it probably does need a patch. Thanks.