Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments in config to make them consistent with docs and code. #10239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xneg
Copy link

@xneg xneg commented Feb 22, 2024

Description

Current config samples contradict the actual code. I was confused what is the right settings and decided to fix samples to make them consistent with docs and code.

Testing done

There are no tests for comment changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@xneg xneg requested a review from a team as a code owner February 22, 2024 13:13
Copy link

cla-assistant bot commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 22, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant