KIP 951 - Phase 1 #4613
Open
KIP 951 - Phase 1 #4613
+109
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchitj
force-pushed
the
dev_parse_flexver_tags
branch
from
adc98bf
to
bf47c62
Compare
emasab
requested changes
May 17, 2024
| @@ -820,6 +820,29 @@ struct rd_kafka_buf_s { /* rd_kafka_buf_t */ | |||
| } \ | |||
| } while (0) | |||
|
|
|||
| /** | |||
| * @brief Read KIP-482 Tags at the current position in the buffer using | |||
There was a problem hiding this comment.
Suggested change
| * @brief Read KIP-482 Tags at the current position in the buffer using | |
| * @brief Read KIP-482 Tags at current position in the buffer using |
| * | ||
| * @param rkbuf buffer to read from | ||
| * @param CurrentLeader is the CurrentLeader to populate. | ||
| * @returns 1 on success, else -1 on parse error. |
There was a problem hiding this comment.
better standardizing on return as returns is an alias for that
Suggested change
| * @returns 1 on success, else -1 on parse error. | |
| * @return 1 on success, else -1 on parse error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken common structs from https://github.com/confluentinc/librdkafka/pull/4609/files.