fix double free for hdrs (pass ownership to message) #4628
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Quuxplusone
approved these changes
Apr 1, 2024
arches-andy
approved these changes
Apr 2, 2024
Co-authored-by: Arthur O'Dwyer <arthur.j.odwyer@gmail.com>
Quuxplusone
approved these changes
Apr 8, 2024
|
@Quuxplusone, @arches-andy just to double check: should someone tap the merge button or will it done at some point automatically?
|
Someone should tap the merge button; but I'm not a maintainer, just an interested bystander, and I think @arches-andy is too. So... @emasab, ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes double free for hdrs variable, more info here: #4627
Rare case when try to send message for non-existing topic/server etc.