Feature/fetch 951 #4631
Open
Feature/fetch 951 #4631
+846
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchitj
reviewed
Mar 21, 2024
|
Completed the tags parsing in the PR #4668 |
anchitj
reviewed
Apr 4, 2024
src/rdkafka.c
Outdated
Comment on lines
3794
to
3895
| new_partition_internals[index].id = mdi->topics[i].partitions[metadata_partition_index].id; | ||
| new_partition_internals->leader_epoch = mdi->topics[i].partitions[metadata_partition_index].leader_epoch; | ||
| new_partition_internals->racks_cnt = mdi->topics[i].partitions[metadata_partition_index].racks_cnt; | ||
| new_partition_internals->racks = rd_malloc( | ||
| sizeof(char *) * new_partition_internals->racks_cnt); | ||
| RD_LIST_FOREACH(rack, mdi->topics[i].partitions[metadata_partition_index].racks, k) { | ||
| new_partition_internals->racks[j] = | ||
| rack; /* no duplication */ | ||
| } | ||
| new_partitions[index].err = mdi->metadata.topics[i].partitions[metadata_partition_index].err; | ||
| new_partitions[index].replica_cnt = mdi->metadata.topics[i].partitions[metadata_partition_index].replica_cnt; | ||
| new_partitions[index].replicas = mdi->metadata.topics[i].partitions[metadata_partition_index].replicas; | ||
| new_partitions[index].id = mdi->metadata.topics[i].partitions[metadata_partition_index].id; | ||
| new_partitions[index].isr_cnt = mdi->metadata.topics[i].partitions[metadata_partition_index].isr_cnt; | ||
| new_partitions[index].isrs = mdi->metadata.topics[i].partitions[metadata_partition_index].isrs; | ||
| new_partitions[index].leader = mdi->metadata.topics[i].partitions[metadata_partition_index].leader; |
There was a problem hiding this comment.
We need to merge with the existing info already present for known partitions, can't directly copy the new metadata directly.
| new_partitions = rd_malloc(new_partition_cnt*sizeof(rd_kafka_metadata_partition_t)); | ||
| cache_partition_index = metadata_partition_index = 0; | ||
| for(index=0;index<new_partition_cnt;index++){ | ||
| if((metadata_partition_index == mdi->metadata.topics[i].partition_cnt) || ((cache_partition_index != partition_size) && (partition_internals[cache_partition_index]->id < mdi->topics[i].partitions[metadata_partition_index].id))){ |
anchitj
requested changes
May 8, 2024
| int index,metadata_partition_index,cache_partition_index; | ||
| char* rack; | ||
|
|
||
| rd_list_t additional_brokers = rd_list_new(10, rd_free); |
There was a problem hiding this comment.
Should be a pointer. And why was the initial count of 10 chosen?
| /* If the topic is in the cache, we need to merge both the information, | ||
| * as broker only has updated information for a known partition or complete information for a new partition | ||
| * and the cache has complete information of an un-updated partition */ | ||
| partition_size = rkmce->rkmce_mtopic.partition_cnt; |
There was a problem hiding this comment.
Better to rename to num_partitions or something like that
mahajanadhitya
force-pushed
the
feature/Fetch_951
branch
from
2275cee
to
31e6c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.