Make ssl.cipher.suites configurable for TLS1.3 #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, it is not possible to setup cipher suites for TLS1.3, as the OpenSSL API uses a different function for those (TLS1.3 ciphers use
SSL_CTX_set_ciphersuiteswhile TLS1.2 ciphers useSSL_CTX_set_cipher_list), which means only TLS1.2 ciphers can be configured.This PR fix this behaviour by discriminating the ciphers set in
ssl.cipher.suitesand calling the right function accordingly.Unlike #4336, this PR doesn't propose any changes to the configuration settings, but rather sort the given ciphers into two lists, one for TLS1.2 ciphers and another one for TLS1.3 ciphers.
This behaviour is also more consistent with the broker configuration.
This also solves discussion #4286.