mv internal/cri/util/deep_copy.go pkg/marshalutil/

[AkihiroSuda]

DeepCopy is depended by nerdctl too

https://github.com/search?q=repo%3Acontainerd%2Fnerdctl%20DeepCopy&type=code

[dmcgowan]

Opened containerd/nerdctl#2854 as an alternative solution. I would put it in the category of better to just copy the function.

[mxpv]

@AkihiroSuda closed this 1 hour ago

Well, I think that's still a viable change. cri package maintains its own version of "utils" package which I'd want to splice with containerd's pkg/ package, since its now a single codebase.

[dmcgowan]

My thought was that we try to keep "util" only packages as internal but we can add useful helper functions in pkg/core packages. Introducing a package with a single function to marshal/unmarshal an object seems against the "A little copying is better than a little dependency" principle that we loosely follow. @mxpv if you have a plan to move some of those internal CRI helpers into a better places, that would be good. I don't think that should be a 2.0 requirement and for these cases breaking client dependency on these little helpers is good.