-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] test composefs #22425
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @edsantiago LGTM |
Ephemeral COPR build failed. @containers/packit-build please check. |
c59cb11
to
0abdfd7
Compare
Failures so far:
|
Tacked in #22422 Maybe file new issues for the other ones |
I'm like 90% sure that 628 is a valid integer, but I don't have enough fingers and toes to confirm. |
569e322
to
d694396
Compare
9b2045e
to
1dfde92
Compare
0ae6ca6
to
870b3db
Compare
870b3db
to
1f9d502
Compare
15dd82b
to
a5b2535
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit a5b2535. @martinpitt, @jelly, @mvollmer please check. |
a5b2535
to
b316e5a
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit b316e5a. @martinpitt, @jelly, @mvollmer please check. |
@containers/podman-maintainers I'm finally confident that we can start testing with composefs. Now what? Proposal:
|
b316e5a
to
85a1271
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
6cf922e
to
64525e9
Compare
880c707
to
f24cdcd
Compare
Signed-off-by: Ed Santiago <santiago@redhat.com>
f24cdcd
to
41ab4c0
Compare
@containers/podman-maintainers remember when I said composefs was looking good? I was way way wrong. I had forgotten the "specialness" of e2e tests, where they need everything spelled out in command-line options. This is nowhere even close to working. |
@containers/podman-maintainers I need a way to convert this containers.conf entry:
...to a command-line option suitable for e2e tests:
|
@edsantiago, could you move it into a separate containers.conf and use |
Just at first glance it looks tricky but I'll try. |
This cannot work because these are storage.conf options not containers.conf options. And looking at the c/storage code there is no way to set pull_options from the cli at all AFAICT |
@giuseppe this is one of the errors seen when only
|
thanks, I think this is just something broken in composefs. I'll take a look |
Signed-off-by: Ed Santiago santiago@redhat.com