Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container name to new image found log, useful when running monitor-only #1870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martini1992
Copy link

  • What your PR contributes
    Simply added the container name to the "Found new image" log, because in monitor-only it's not clear which container needs to be recreated, also there are duplicate log lines if the same image is used in multiple containers (MariaDB etc). I added it to the end of the message to limit issues if people are parsing the log message in their workflows.

  • Which issues it solves
    No issue, I can open one if required but for such a tiny change I thought any discussion could happen here.

  • Tests that verify the code your contributing
    Unable to get a dev env set up, there are no instructions on the project. Unable to build a test docker image that runs. The Go compiler doesn't complain though, which from such a small change I would expect it to if I'd gone wrong.

  • Updates to the documentation
    None required

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant