New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/worker thread #1003
base: preview
Are you sure you want to change the base?
Feat/worker thread #1003
Conversation
✅ Deploy Preview for continuedev canceled.
|
@Iamshankhadeep I finally got around to testing this locally. Everything looks perfect, including the packaging with esbuild (you solved this very cleanly!). But it seems that VS Code isn't doing well with worker threads. In debugging mode, the worker never responds (can verify this by placing a breakpoint in the on message function). Then when I packaged the extension and installed it as a .vsix, everything seemed to work fine, until using the @ codebase context provider causes the extension host to crash. Had you seen the same issue or have any ideas? microsoft/vscode#88386 seems like the most closely related issue, though seemed to have been solved |
I was having the same issue while testing on this
I can think of one issue probably using @ codebase opening too many worker threads before terminating previous theard crasing, or probably adding some smart resourse limit |
@Iamshankhadeep the worker limit is a good idea. When you had the same problem, was it in debug mode, or was this with a packaged version of the extension? I would be curious whether you end up seeing the same problem that I did after running |
let me try that and I'll let you know 🔥 |
fixes #856