Con-991-a: Diff Manager Improvements #1198
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: Work was started in this MR.
I started this new branch as the last one got messy.
This MR makes two improvements to vertical diff managers:
1) Open diffs are adjusted to user edits to the file
2) Sequentially opened diffs will be handled properly
Test Evidence:
Accept all/Reject all
simplescreenrecorder-2024-04-27_22.41.48.mp4
Mixing individual accept/rejects and grouped accept/reject alls:
simplescreenrecorder-2024-04-27_22.42.50.mp4
With red:
simplescreenrecorder-2024-04-29_10.05.52.mp4
With user edits before and between blocks
simplescreenrecorder-2024-04-29_10.09.47.mp4
Attempt to open multiple diffs and only one is allowed at a time (and diff is created at correct (new) position)
Block above:
simplescreenrecorder-2024-04-29_16.52.05.mp4
Block below:
simplescreenrecorder-2024-04-29_13.10.58.mp4
Ctrl I (No new selection)
simplescreenrecorder-2024-04-27_22.46.52.mp4
Ctrl I (New selection)
simplescreenrecorder-2024-04-29_16.53.51.mp4