Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add python 3.12 support #3660

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

theoparis
Copy link

WIP

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

@theoparis
Copy link
Author

theoparis commented Apr 2, 2024

Upon testing new changes I ran out of swap space running pip install -v . (8gb ram + zram) and it crashed my entire window manager.

@jessebot
Copy link

jessebot commented Apr 23, 2024

@theoparis is that necessary with the extra GHA jobs that were added? It looks like the 3.12 tests are failing (at least partially) because of trainer, which @eginhard submitted a PR for here: coqui-ai/Trainer#143 (which I just realized you also reacted to 😅 ) but it needs to be merged and released by @erogol.

In the meantime, for the sake of the test, can you point your trainer version at @eginhard's test branch here?
https://github.com/eginhard/coqui-trainer/tree/py312

Then, if you're still out of ram, I or perhaps other passersby, can help test this locally to verify it's all good to go, if you need, but the GitHub jobs would probably finish testing for 3.12 (or at least fail on something else).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants