feat(middleware): v4 experimental middleware #986
Conversation
…ooks to the middleware. This is specially useful when you want to use transaction data to populate things like logs or spans in a trace enriching the experience and connecting the dots with observability.
| //go:embed error_template.html error_template.html | ||
| var embededTemplates embed.FS |
There was a problem hiding this comment.
So... are these going to be html/templates or just html code? At first read I thought they were not static html files only.
In summary:
- are these meant to be static html?
- wouldn't be more interesting to use
html/templatetemplates that can be filled with details about the transaction? E.g. "Some error found. Contact your admin with this code: { < the transaction ID> }"`
If we use static html, maybe removing the "_template" in the name will make more sense, and use "default_error.html" and "default_interruption.html" instead?
| "net/http" | ||
|
|
||
| "github.com/corazawaf/coraza/v3" | ||
| ) | ||
|
|
||
| //go:embed error_template.html error_template.html |
There was a problem hiding this comment.
| //go:embed error_template.html error_template.html | |
| //go:embed error_template.html interruption_template.html |
That's just to fix this. But I suggest changing to "default_error.html" and "default_interruption.html", pending on the next comment.
| errorTemplate, err = embededTemplates.ReadFile("error_template.html") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| interruptionTemplate, err = embededTemplates.ReadFile("interruption_template.html") | ||
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
Shouldn't we avoid error handling at the init level? Can we have a readTemplates method instead that will be called by the middleware?
| // Interruption template supports variables in macro expansion format: %{var} | ||
| // Variables are: |
There was a problem hiding this comment.
Macro expansion as in SecRule macro expansion?
|
@jptosso Care to take a look at comments? |
|
And provide a description about what this PR does? |
No description provided.