fix: break hybrid router with a custom typed field #20349
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
both
gogoproto.Merge
andproto.Merge
(v2) will fail when merging custom typed fields as the hybrid router does. This patch demonstrates it.Therefore
RotuerService.InvokeTyped
will not function in all cases as it relies onproto.Merge
(used in runtime/v1 and not at all runtime/v2). I propose we coalesce onInvoke
fromInvokeTyped
andInvokeUntyped
and, given we will only support gogo types in the router, a simpler router like this one:cosmos-sdk/runtime/v2/manager.go
Lines 615 to 649 in 8df6a87
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...