Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color output on Windows #551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix color output on Windows #551

wants to merge 1 commit into from

Conversation

8LWXpg
Copy link

@8LWXpg 8LWXpg commented Mar 20, 2024

Fix #128

I simply compare util_windows.go with util_unix.go, and setting c.Stdout, c.Stderr seems to have resolve this issue.

Screenshot

image

@8LWXpg
Copy link
Author

8LWXpg commented Mar 21, 2024

A question for this code:
Returning stdout and stderr then io.Copy seems redundant, since setting c.Stdout = os.Stdout and c.Stderr = os.Stderr basically does the same thing. Is there reason for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colour of gin's log
1 participant