changed int to uint16_t for port variables #1436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for redisLibeventAttach method, and added casting to uint16_t when redisLibeventAttach method is called
eakraly
requested changes
Feb 21, 2024
src/apps/relay/dbdrivers/dbd_redis.c
Outdated
| @@ -268,7 +268,7 @@ redis_context_handle get_redis_async_connection(struct event_base *base, redis_s | |||
| } | |||
| } | |||
|
|
|||
| ret = redisLibeventAttach(base, co->host, co->port, co->password, atoi(co->dbname)); | |||
| ret = redisLibeventAttach(base, co->host, (uint16_t)co->port, co->password, atoi(co->dbname)); | |||
There was a problem hiding this comment.
Pls review if you can change the type to uint16_t in the struct rather than adding cast
|
Thank you @WHYHD for the contribution |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/apps/relay/dbdrivers/dbd_redis.c
Outdated
| @@ -268,7 +268,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| ret = redisLibeventAttach(base, co->host, co->port, co->password, atoi(co->dbname)); | |||
| ret = redisLibeventAttach(base, co->host, (uint16_t)co->port, co->password, atoi(co->dbname)); | |||
Check warning
Code scanning / PREfast
'co->dbname' could be '0'.
jonesmz
reviewed
Mar 20, 2024
| @@ -134,9 +134,9 @@ static Ryconninfo *RyconninfoParse(const char *userdb, char **errmsg) { | |||
| } else if (!strcmp(s, "secret")) { | |||
| co->password = strdup(seq + 1); | |||
| } else if (!strcmp(s, "port")) { | |||
| co->port = (unsigned int)atoi(seq + 1); | |||
| co->port = atoi(seq + 1); | |||
There was a problem hiding this comment.
don't you need a cast to uint16_t to avoid the compiler warning about precision loss?
jonesmz
reviewed
Mar 20, 2024
| @@ -210,7 +210,7 @@ redis_context_handle get_redis_async_connection(struct event_base *base, redis_s | |||
| } | |||
|
|
|||
| if (co->port) { | |||
| port = (int)(co->port); | |||
| port = (co->port); | |||
There was a problem hiding this comment.
parenthesis aren't needed here anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach:
This is same scale example to gain feedback on changing ports to unint16_t. I would like to make these changes everywhere so any feedback is welcome.