Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: update voting_period is not tested #1017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 26, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d71c53c) 33.05% compared to head (4f6f35a) 25.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   33.05%   25.06%   -7.99%     
==========================================
  Files         126      125       -1     
  Lines       20014    20012       -2     
==========================================
- Hits         6616     5017    -1599     
- Misses      12339    14177    +1838     
+ Partials     1059      818     -241     
Flag Coverage Δ
integration_tests ?
integration_tests_byzantine ?
integration_tests_gov ?
integration_tests_grpc ?
integration_tests_ibc 24.75% <ø> (-0.02%) ⬇️
integration_tests_ledger ?
integration_tests_slow ?
integration_tests_solomachine ?
integration_tests_upgrade 9.95% <ø> (ø)
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe marked this pull request as ready for review October 26, 2023 02:56
@mmsqe mmsqe requested a review from a team as a code owner October 26, 2023 02:56
Signed-off-by: mmsqe <mavis@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant