Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: protobuf message urls should not change #1044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Problem: protobuf message urls should not change #1044

wants to merge 1 commit into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 18, 2024 •
edited

Solution:

  • revert the package name change introduced in Problem: sdk 47 is not integrated聽#1023.
  • don't remember why we have to change it there, but it seems not nesserary, revert it to keep it backward compatible.
  • change proto file folder structure to match the package name instead.

馃懏馃徎馃懏馃徎馃懏馃徎 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 馃懏馃徎馃懏馃徎馃懏馃徎

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner April 18, 2024 02:37
yihuang
yihuang commented Apr 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mmsqe
Copy link
Contributor

mmsqe commented Apr 18, 2024

I rmb since proto paths need to match folder paths

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 18, 2024 •
edited

I rmb since proto paths need to match folder paths

yeah, I also changed the folder, it'll be headache to break the msg urls.

@yihuang
Problem: protobuf message urls should not change
301a898 
Solution:
- revert the package name change introduced in crypto-org-chain#1023.
- don't remember why we have to change it there, but it seems not
  nesserary, revert it to keep it backward compatible.

Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

match protobuf package name with directory structure

fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yihuang @mmsqe