Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src/SOURCE_DATE_EPOCH to release tree #14574

Conversation

straight-shoota
Copy link
Member

The Crystal compiler version info (crystal --version) includes a date representing the chronological aspect of the comiler version.
It's supposed to represent the date of the source code. But this information is not available in a bare snapshot of the source tree. The Makefile tries to read the date of the last commit from git, which requires git and the repository.

This patch adds a file src/SOURCE_DATE_EPOCH which sits alongside src/VERSION to have both data available next to each other.
It gets automatically populated in the release process and is removed afterwards. So it should only be available in the source tree of tagged release commits.

A practical use case for this is NixOS/nixpkgs#306765 as well as any other package build that doesn't use the git repository.

@straight-shoota straight-shoota added this to the 1.13.0 milestone May 10, 2024
@straight-shoota straight-shoota merged commit 8d14782 into crystal-lang:master May 13, 2024
61 checks passed
@straight-shoota straight-shoota deleted the infra/src-SOURCE_DATE_EPOCH branch May 13, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants