This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
Add a background color for the OPTIONS requests #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coudenysj
commented
Feb 23, 2018
coudenysj
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | Apache License 2.0 |
|
Hi @coudenysj. Unfortunately that PR is incomplete. You also need to update _badge.sass, and re-generate the CSS file. Could you do that? Cheers! |
|
What should be changed in _badge.sass? The methods are not used there. Plus: I unfortunately don't have the tools to process sass files :/ |
|
Okay. I'll take over your PR, then :) No big deal! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.