feat: replace cubestore's GCP service account with WorkloadIdentity #8148
+212
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
BenHaimItay
changed the title
|
@BenHaimItay Thanks for submitting it! We're open to having identity support for GCS! For this PR, we'd need to
|
|
My pleasure :)
|
|
Hi @paveltiunov, In addition, the cloud-storage should be forked into your org account :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#4434
Description of Changes Made (if issue reference is not provided)
in cubestore/cubestore/Cargo.toml upgrade from cloud-storage 0.7.0 to the 0.11.1 fork by @dark0dave additionally make sure to lock gcp_auth to 0.7.4 and time to 0.3.17 otherwise it won't compile with the toolchain channel = "nightly-2022-11-03". The original cloud-storage does not seem to be actively maintained.
cloud-storage = { git = "https://github.com/dark0dave/cloud-storage-rs", branch = "master", features = ["global-client", "sync", "native-tls"] }
gcp_auth = { version = "=0.7.4" }
time = { version = "=0.3.17" }
From remotefs/gcs.rs remove ensure_credentials_init to remove the requirement on the environment variable.
Adapt remotefs/gcs.rs to cloud-storage 0.11.1 + updated list_with_metadata and imports.