feat(cubesql): Send expressions as objects #8216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waralexrom
changed the base branch from
master
to
cubesql/in-subquery-rewrite-empty-source
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
MazterQyou
approved these changes
May 7, 2024
| if (match) { | ||
| const args = match[3].split(','); | ||
| args.push(`return \`${match[4]}\``); | ||
| try { |
There was a problem hiding this comment.
I still feel that this large try block can catch something unrelated to JSON.parse, but this may be irrelevant if we consider that any failure must return memberExpression as is.
paveltiunov
approved these changes
May 8, 2024
waralexrom
force-pushed
the
cubesql/in-subquery-rewrite-empty-source
branch
from
e35c837
to
4c97f75
Compare
Base automatically changed from
cubesql/in-subquery-rewrite-empty-source
to
master
May 14, 2024 15:24
waralexrom
force-pushed
the
cubesql/expressions-as-objects
branch
from
6b68ed2
to
ccf5e6c
Compare
paveltiunov
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]