Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Flatten list expression rewrites to improve performance #8248

Merged
merged 1 commit into from
May 24, 2024

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented May 8, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR introduces flat list expression rewrites, flattening:

  • Projection expressions
  • Aggregate group and aggr expressions
  • UDF arguments
  • Window expressions

Fixes #6307

@MazterQyou MazterQyou requested review from a team as code owners May 8, 2024 17:08
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 0:30am

@MazterQyou MazterQyou force-pushed the cubesql/rewrite-flat-exprs branch 3 times, most recently from 22c12ec to a3fbbfb Compare May 16, 2024 15:05
@MazterQyou MazterQyou force-pushed the cubesql/rewrite-flat-exprs branch 2 times, most recently from 1747482 to 0e42968 Compare May 23, 2024 01:10
@paveltiunov paveltiunov changed the title feat(cubesql): Flatten list expression rewrites feat(cubesql): Flatten list expression rewrites to improve performance May 23, 2024
@MazterQyou MazterQyou merged commit 96c1549 into master May 24, 2024
64 checks passed
@MazterQyou MazterQyou deleted the cubesql/rewrite-flat-exprs branch May 24, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PG_SQL - Can't find rewrite due to [] AST node limit reached/Can't find rewrite due to timeout reached
2 participants