feat: sql api over http #8254
Open
feat: sql api over http #8254
+971
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vasilev-alex
force-pushed
the
cubesql-over-http
branch
from
1b1a0aa
to
e6c45a4
Compare
vasilev-alex
force-pushed
the
cubesql-over-http
branch
from
a2f9146
to
c7b695e
Compare
ovr
reviewed
May 29, 2024
| ); | ||
|
|
||
| insta::assert_snapshot!( | ||
| "TableValue serializer", |
ovr
reviewed
May 29, 2024
| try { | ||
| await server.execSql(req.body.query, res, req.context?.securityContext); | ||
| } catch (error: any) { | ||
| res.status(500).end(JSON.stringify(error)); |
There was a problem hiding this comment.
It's better to use this.handleError because some types of errors can confidential details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]