Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Remove prefix underscore from aliases #8266

Merged
merged 4 commits into from
May 15, 2024

Conversation

Nikita-str
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@Nikita-str Nikita-str requested review from a team as code owners May 15, 2024 14:49
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 15, 2024
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm
examples-react-pivot-table ⬜️ Ignored (Inspect) May 15, 2024 9:06pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:06pm

@Nikita-str Nikita-str changed the title fix(cubesql): prefix underscores in aliases fix(cubesql): Remove prefix underscore from aliases May 15, 2024
@Nikita-str Nikita-str merged commit 24e8977 into master May 15, 2024
76 checks passed
@Nikita-str Nikita-str deleted the C943-WHERE-segment-IS-FALSE branch May 15, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants