Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix some CURLINFO examples #13559

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 9 additions & 4 deletions docs/libcurl/opts/CURLINFO_ACTIVESOCKET.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,19 @@ int main(void)
/* Do not do the transfer - only connect to host */
curl_easy_setopt(curl, CURLOPT_CONNECT_ONLY, 1L);
res = curl_easy_perform(curl);

/* Extract the socket from the curl handle */
res = curl_easy_getinfo(curl, CURLINFO_ACTIVESOCKET, &sockfd);

if(res != CURLE_OK) {
printf("Error: %s\n", curl_easy_strerror(res));
curl_easy_cleanup(curl);
return 1;
}

/* Extract the socket from the curl handle */
res = curl_easy_getinfo(curl, CURLINFO_ACTIVESOCKET, &sockfd);
if(!res && sockfd != CURL_SOCKET_BAD) {
/* operate on sockfd */
}

curl_easy_cleanup(curl);
}
}
~~~
Expand Down
13 changes: 9 additions & 4 deletions docs/libcurl/opts/CURLINFO_LASTSOCKET.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,19 @@ int main(void)
/* Do not do the transfer - only connect to host */
curl_easy_setopt(curl, CURLOPT_CONNECT_ONLY, 1L);
res = curl_easy_perform(curl);

/* Extract the socket from the curl handle */
res = curl_easy_getinfo(curl, CURLINFO_LASTSOCKET, &sockfd);

if(res != CURLE_OK) {
printf("Error: %s\n", curl_easy_strerror(res));
curl_easy_cleanup(curl);
return 1;
}

/* Extract the socket from the curl handle */
res = curl_easy_getinfo(curl, CURLINFO_LASTSOCKET, &sockfd);
if(!res && sockfd != -1) {
/* operate on sockfd */
}

curl_easy_cleanup(curl);
}
}
~~~
Expand Down
2 changes: 1 addition & 1 deletion docs/libcurl/opts/CURLINFO_NUM_CONNECTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ int main(void)
if(res == CURLE_OK) {
long connects;
res = curl_easy_getinfo(curl, CURLINFO_NUM_CONNECTS, &connects);
if(res)
if(!res)
printf("It needed %ld connects\n", connects);
}
curl_easy_cleanup(curl);
Expand Down
2 changes: 1 addition & 1 deletion docs/libcurl/opts/CURLINFO_OS_ERRNO.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ int main(void)
if(res != CURLE_OK) {
long error;
res = curl_easy_getinfo(curl, CURLINFO_OS_ERRNO, &error);
if(res && error) {
if(!res && error) {
printf("Errno: %ld\n", error);
}
}
Expand Down
19 changes: 15 additions & 4 deletions docs/libcurl/opts/CURLINFO_PROXY_SSL_VERIFYRESULT.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ Pass a pointer to a long to receive the result of the certificate verification
that was requested (using the CURLOPT_PROXY_SSL_VERIFYPEER(3)
option. This is only used for HTTPS proxies.

0 is a positive result. Non-zero is an error.

# EXAMPLE

~~~c
Expand All @@ -43,14 +45,23 @@ int main(void)
if(curl) {
CURLcode res;
long verifyresult;

curl_easy_setopt(curl, CURLOPT_URL, "https://example.com");
curl_easy_setopt(curl, CURLOPT_PROXY, "https://proxy:443");

res = curl_easy_perform(curl);
if(res)
if(res) {
printf("error: %s\n", curl_easy_strerror(res));
curl_easy_getinfo(curl, CURLINFO_PROXY_SSL_VERIFYRESULT, &verifyresult);
printf("The peer verification said %s\n", verifyresult?
"fine" : "bad");
curl_easy_cleanup(curl);
return 1;
}

res = curl_easy_getinfo(curl, CURLINFO_PROXY_SSL_VERIFYRESULT,
&verifyresult);
if(!res) {
printf("The peer verification said %s\n",
(verifyresult ? "bad" : "fine"));
}
curl_easy_cleanup(curl);
}
}
Expand Down
17 changes: 13 additions & 4 deletions docs/libcurl/opts/CURLINFO_SSL_VERIFYRESULT.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,22 @@ int main(void)
if(curl) {
CURLcode res;
long verifyresult;

curl_easy_setopt(curl, CURLOPT_URL, "https://example.com");

res = curl_easy_perform(curl);
if(res)
if(res) {
printf("error: %s\n", curl_easy_strerror(res));
curl_easy_getinfo(curl, CURLINFO_SSL_VERIFYRESULT, &verifyresult);
printf("The peer verification said %s\n", verifyresult?
"BAAAD":"fine");
curl_easy_cleanup(curl);
return 1;
}

res = curl_easy_getinfo(curl, CURLINFO_SSL_VERIFYRESULT,
&verifyresult);
if(!res) {
printf("The peer verification said %s\n",
(verifyresult ? "bad" : "fine"));
}
curl_easy_cleanup(curl);
}
}
Expand Down