Remove "fischerandom" from UCI combo variants #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UCI uses boolean option "UCI_Chess960" or combo UCI_Variant value "var chess960"
Boolean option "UCI_Fischerandom" and combo UCI_Variant value "var fischerandom" are not supported.
Resolves #667
This commit avoids an inconsistent behaviour of CC for FRC/Chess960 when an engine (here: Fairy-Stockfish, versions 10.4 and newer) has both boolean option
UCI_Chess960
and combo optionUCI_Variant
and not using value var chess960 (like Sjaak II) but var fischerandom. CC reads var fischerandom and activatesFRCBoard
but inconsistently issues setoption name UCI_Variant value chess960. The engine then remains in standard chess mode and loses.Older versions of Fairy-Stockfish did not have value var fischerandom and thus the boolean option UCI_Chess960 was used without problem.
This PR removes var fischerandom from the values of
UCI_Variant
.Tested as working with Fairy.Stockfish 10.3, Fairy.Stockfish 10.4, Fairy.Stockfish 14 and Sjaak II version 1.3.1.
This can be considered as a work-around before more profound solution is in place.
HTH