chore: update sprt completion conditions to match theory #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions which must be met for H0 or H1 to be accepted have been updated to use closed intervals, matching the theory found in the original paper by Abraham Wald.
|
True, that would comply to the theory. In practice, the difference will be very minor as far as I can see. |
|
I was just thinking it would be good to make it consistent, but feel free to close this pr if you think this is unnecessary. |
|
No offense, I think this PR is fine. |
|
@alwey Please decide what to do with this pr and close it. No hard feelings if you choose not to merge it, I just wanted to finish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions which must be met for$H_0$ or $H_1$ to be accepted have been updated to use closed intervals $\left]-\infty, B\right]$ and $\left[A, \infty\right[$ respectively, matching the theory found in the original paper by Abraham Wald.