Fixed object count in analytics for skeletons and tracks #7883
Conversation
WalkthroughThe recent updates address issues in the analytics for skeleton tracks and shapes, ensuring accurate object counts in reports. Specifically, changes were made to the filtering and counting logic in the annotation speed extractor class, excluding certain shape types and adjusting track count calculations. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
changelog.d/20240510_095000_boris_fixed_analytics_for_skeletons.md
Outdated
Show resolved
Hide resolved
changelog.d/20240510_095034_boris_fixed_analytics_for_skeletons.md
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- changelog.d/20240510_095000_boris_fixed_analytics_for_skeletons.md (1 hunks)
- changelog.d/20240510_095034_boris_fixed_analytics_for_skeletons.md (1 hunks)
- cvat/apps/analytics_report/report/primary_metrics/annotation_speed.py (4 hunks)
Additional comments not posted (4)
cvat/apps/analytics_report/report/primary_metrics/annotation_speed.py (4)
21-21: Import statement change is correct and necessary.
78-81: Exclusion ofSKELETONshapes is logical and aligns with the objective.
Line range hint
87-123: Changes inget_track_countensure accurate counting of tracks by excludingSKELETONshapes.
Line range hint
75-127: Integration of updated counting functions in thecalculatemethod ensures consistency and accuracy.
| ### Fixed | ||
|
|
||
| - Analytic reports incorrect count of objects for a skeleton track/shape | ||
| (<https://github.com/cvat-ai/cvat/pull/7883>) |
There was a problem hiding this comment.
Add angle brackets around the link for consistency.
- (<https://github.com/cvat-ai/cvat/pull/7883>)
+ (<https://github.com/cvat-ai/cvat/pull/7883>)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ### Fixed | ||
|
|
||
| - Analytic reports incorrect number of objects for a track (always less by 1) | ||
| (<https://github.com/cvat-ai/cvat/pull/7883>) |
There was a problem hiding this comment.
Add angle brackets around the link for consistency.
- (<https://github.com/cvat-ai/cvat/pull/7883>)
+ (<https://github.com/cvat-ai/cvat/pull/7883>)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| (<https://github.com/cvat-ai/cvat/pull/7883>) |
…t applied to annotation speed anymore (#7898) <!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context Depends on ##7883 ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected an issue where analytic reports showed an incorrect count of objects for skeleton tracks and shapes. - **Improvements** - Renamed metrics related to annotation speed from total to average for jobs, tasks, and projects. - Updated descriptions for annotation speed metrics to specify the number of objects per hour. - Removed unnecessary clamping function for working time statistics. These changes enhance the accuracy and clarity of analytic reports, providing more meaningful insights into annotation speeds and object counts. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
Improvements