Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exception management to avoid errors when process is not launched #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidgfb
Copy link

No description provided.

Copy link

@zlataovce zlataovce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use bare except, it catches all exceptions and makes debugging impossible. Also see my comment on the previous pull request.

Copy link

@zlataovce zlataovce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the PEP8 style guide.
E231 missing whitespace after ‘,’

@zlataovce
Copy link

zlataovce commented Nov 29, 2020

Also as I said in the previous pull request, no need to download specifically Python 3.9.
Example readme with Markdown:

Important
Download Python 3.5 or newer from here and install it (tick the option "Add Python to PATH").
Open the command prompt and type: python -m pip install pymem pywin32

Run CS:GO before running this script. You will need to run this script with administrator privileges.

Copy link

@zlataovce zlataovce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address = clientLpBaseOfDll + search(rb'\x83\xF8.\x8B\x45\x08\x0F',
You have a mistake at line 13, it needs to be client.lpBaseofDll not clientLpBaseOfDll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants