New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix+feat: fix infinte-loading due to non-call of callback and expose error message into frontend #2516
Open
ilsubyeega
wants to merge
9
commits into
danny-avila:main
Choose a base branch
from
ilsubyeega:fix/oauth-stragy-no-callback
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix+feat: fix infinte-loading due to non-call of callback and expose error message into frontend #2516
ilsubyeega
wants to merge
9
commits into
danny-avila:main
from
ilsubyeega:fix/oauth-stragy-no-callback
+106
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilsubyeega
changed the title
(WIP) fix: return callbacks when social registration has been closed
fix+feat: fix infinte-loading due to non-callback calling and expose error message into frontend
Apr 27, 2024
ilsubyeega
changed the title
fix+feat: fix infinte-loading due to non-callback calling and expose error message into frontend
fix+feat: fix infinte-loading due to non-call of callback and expose error message into frontend
Apr 27, 2024
thanks! looks great, will test it and merge by end of weekend |
danny-avila
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
danny-avila
requested changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a new user tried to sign up with social login, while registration disabled, the callback won't being called and would have to wait for a long time due to no callbacks. Also This PR also introduces append
error
parameter to/login
frontend route to show the error of oauth.Backend
passport.authenticate
to handle the error message and then redirect into./login?error=<MESSAGE>
.Frontend
Login.tsx
: Extract?error
parameters from the URL and show it as an error message.customError
state sinceerror
state always localized.customError
usage.Concerns
customError
state is duplicated witherror
state. And might need to change names to avoid confusion.Since I'm not used on express.js and React, Please let me know if i wrong of this
Change Type
Please delete any irrelevant options.
Testing
Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.
Test Configuration:
I have no idea which unit test should i create.
Tested with
ALLOW_SOCIAL_LOGIN=true
andALLOW_SOCIAL_REGISTRATION=false
env.Checklist
Please delete any irrelevant options.