Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add import for ButtonProps and use forwardRef and remove unused View import #261

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Joehoel
Copy link
Contributor

@Joehoel Joehoel commented Apr 16, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 94601f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 16, 2024

@Joehoel is attempting to deploy a commit to the ronin-tech Team on Vercel.

A member of the Team first needs to authorize it.

@Joehoel Joehoel changed the title fix: add import for ButtonProps and use forwardRef fix: add import for ButtonProps and use forwardRef Apr 16, 2024
@Joehoel Joehoel changed the title fix: add import for ButtonProps and use forwardRef fix: add import for ButtonProps and use forwardRef and remove unused View import Apr 16, 2024
@@ -3,7 +3,7 @@ import { Link, Stack } from 'expo-router';
import { Text, View } from 'react-native';
<% } else if (props.stylingPackage?.name === "unistyles") { %>
import { createStyleSheet, useStyles } from 'react-native-unistyles'
import { Text, View } from 'react-native';
import { Text } from 'react-native';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this View is necessary given lines 60-70

Copy link
Owner

@danstepanov danstepanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants