-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eas flag for dev client setup #266
feat: eas flag for dev client setup #266
Conversation
🦋 Changeset detectedLatest commit: 402ee25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@dannyhw is attempting to deploy a commit to the ronin-tech Team on Vercel. A member of the Team first needs to authorize it. |
I think potentially we could run prebuild for the user which would also get them to configure the bundle identifiers and generate the ios/android folders. The only reason I didn't add it is because you could probably get by with just letting eas generate those on the cloud. |
@dannyhw is this ready for review based on our last discussion? |
@danstepanov hey, had a really busy week so haven't had a chance to iterate on it since then. There's a few changes I'd like to make still. |
@danstepanov Hey sorry for the delay I had a lot going on. Made some updates based on what we spoke about. |
@dannyhw Can you make this part of the core CLI questions? Not just a flag. |
Hey @danstepanov, it should come up as a question already. I made it a flag more because I wasn't sure if it fit as a "package". |
060c31f
to
673f031
Compare
@dannyhw mind rebasing with |
@danstepanov merged in changes and conflicts resolved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Aims to add an option for initialising a project with eas
Related Issue
Motivation and Context
Simpler eas setup
How Has This Been Tested?
Screenshots (if appropriate):
ces-with-eas.mp4
adjusted output