Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eas flag for dev client setup #266

Merged
merged 7 commits into from
May 16, 2024

Conversation

dannyhw
Copy link
Contributor

@dannyhw dannyhw commented Apr 19, 2024

Description

Aims to add an option for initialising a project with eas

Related Issue

Motivation and Context

Simpler eas setup

How Has This Been Tested?

Screenshots (if appropriate):

ces-with-eas.mp4

adjusted output

image

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 402ee25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-expo-stack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 19, 2024

@dannyhw is attempting to deploy a commit to the ronin-tech Team on Vercel.

A member of the Team first needs to authorize it.

@dannyhw dannyhw changed the title feat: eas flag for dev client setup wip: feat: eas flag for dev client setup Apr 19, 2024
@dannyhw dannyhw changed the title wip: feat: eas flag for dev client setup feat: eas flag for dev client setup Apr 20, 2024
@dannyhw dannyhw marked this pull request as ready for review April 20, 2024 13:29
@dannyhw
Copy link
Contributor Author

dannyhw commented Apr 23, 2024

I think potentially we could run prebuild for the user which would also get them to configure the bundle identifiers and generate the ios/android folders. The only reason I didn't add it is because you could probably get by with just letting eas generate those on the cloud.

@danstepanov
Copy link
Owner

@dannyhw is this ready for review based on our last discussion?

@dannyhw
Copy link
Contributor Author

dannyhw commented Apr 30, 2024

@danstepanov hey, had a really busy week so haven't had a chance to iterate on it since then. There's a few changes I'd like to make still.

@dannyhw
Copy link
Contributor Author

dannyhw commented May 6, 2024

@danstepanov Hey sorry for the delay I had a lot going on. Made some updates based on what we spoke about.

@danstepanov
Copy link
Owner

@dannyhw Can you make this part of the core CLI questions? Not just a flag.

@dannyhw
Copy link
Contributor Author

dannyhw commented May 14, 2024

Hey @danstepanov, it should come up as a question already. I made it a flag more because I wasn't sure if it fit as a "package".

@danstepanov
Copy link
Owner

@dannyhw mind rebasing with main? I'll merge and take it from there :)

@dannyhw
Copy link
Contributor Author

dannyhw commented May 15, 2024

@danstepanov merged in changes and conflicts resolved 👍

Copy link
Owner

@danstepanov danstepanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danstepanov danstepanov merged commit 2e19daf into danstepanov:main May 16, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants