Add Dropbox connector #956
Conversation
goldflag
commented
Jan 17, 2024
•
goldflag
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
goldflag
force-pushed
the
by/dropbox-connector
branch
from
a18b572
to
8ef9720
Compare
| self.dropbox_client.sharing_create_shared_link_with_settings(path) | ||
| ) | ||
| return link_metadata.url | ||
| except ApiError as err: |
There was a problem hiding this comment.
This will fail on the same doc if the doc is updated and an update is fetched via Danswer. The error is something like: CreateSharedLinkWithSettingsError('shared_link_already_exists') so we should first check if a shared link exists?
| downloaded_file = self._download_file(entry.path_display) | ||
| link = self._get_shared_link(entry.path_display) | ||
| try: | ||
| text = downloaded_file.decode("utf-8") |
There was a problem hiding this comment.
We want to read the file extension and use different handling based on that. We can just assume that .pdf, .docx, .doc etc all follow their expected formats. There's another PR out right now which handles a few of these types, perhaps you can refactor their file handling code to cover these cases as well. Users will be upset if they end up missing a lot of files which they expect to get pulled in.
The important ones would be Doc, Docx, Txt, Excel, PDF, PPT. No need to address this yet though, let me review and merge the other PR first
| ) | ||
| ) | ||
| except Exception as e: | ||
| print( |
There was a problem hiding this comment.
Here and in other places - We try not to use print anywhere, we have a standard logger that we import and use throughout
| @@ -0,0 +1,202 @@ | |||
| "use client"; | |||
There was a problem hiding this comment.
I'm not well versed in frontend code but I don't think you need a review from Chris on this, the functionality is all good so I think the frontend code is safe to go in as is
