Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshair plugin runtime error on moving cursor out fix #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n-gist
Copy link

@n-gist n-gist commented Apr 9, 2023

It is difficult to provide an example to test as the problem was discovered when using electron + react desktop application, but here is description and a screenshot of the error.

Having several graphs synchronized using synchronize plugin and having crosshair plugin used on them, doing these steps causes the error:

  1. Zooming in one of the synced graphs
  2. Moving cursor in and out of application bounds right after that (without clicking anywhere after zooming in)

crosshair-error

Checking of selPoints_.length !== 0 fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant