Fixing issue with no legend showing for touch events. #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving the lastTouch and looking to see if other functions wipe it before passing a special param to tell the other functions that it's a touchOVER.
Adding touchOVER check to the pageX/Y as it only exists under touches for touch events.
In testing on different devices it seems changedTouches is better supported cross platform, using this instead of the the touches object. Roughly tested on iOS and Android.
adrianiainlam
added a commit
to adrianiainlam/dygraphs
that referenced
this pull request
Jul 31, 2018
Shinbar
pushed a commit
to Shinbar/dygraphs
that referenced
this pull request
Apr 13, 2020
on touch enabled devices. Based off danvk#723 by kbaggot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have been using your library for a while and am now using it on some mobile projects and noticed issue #400 and thought it was something I am going to run into soon.
Had a quick think about it and I believe this pull request would fix the issue satisfactorily, the only thing I don't like is the test inside the .pageY and .pageX functions as they were very clean, but I can't see another way of doing it without entering more of the functions associated with the lookup of the coords. So I haven't written any tests for it and welcome your opinion first.
Thanks for all your work on this, it's a great library.