Improvements to auth login command
#1370
Open
+131
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
changed the title
auth login command
pietern
reviewed
Apr 18, 2024
pietern
reviewed
Apr 18, 2024
lennartkats-db
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes a couple of improvements to the "auth login" command:
setHostfunction. Before host in profile would be preferred over the host specified as a positional arg. This PR fixes the bug for bothauth loginandauth tokencommands.Tests
Manually and unit tests.
Validation of host:
Screen.Recording.2024-04-16.at.6.51.46.PM.mov