-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support IS_OWNER as a top-level permission #1387
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
+ Coverage 52.25% 52.66% +0.40%
==========================================
Files 317 335 +18
Lines 18004 19228 +1224
==========================================
+ Hits 9408 10126 +718
- Misses 7903 8344 +441
- Partials 693 758 +65 ☔ View full report in Codecov by Sentry. |
@@ -57,7 +57,7 @@ func giveAccessForWorkspaceRoot(ctx context.Context, b *bundle.Bundle) error { | |||
return err | |||
} | |||
|
|||
_, err = w.UpdatePermissions(ctx, workspace.WorkspaceObjectPermissionsRequest{ | |||
_, err = w.SetPermissions(ctx, workspace.WorkspaceObjectPermissionsRequest{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: this changes the existing behavior; would be something to split out into a separate PR.
Changes
WIP PR related to a decision doc.
Related: #1386
Tests
Unit tests, manual experimentation.