Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noisy azure_workspace_resource_id field not provided message for non-production Databricks deployments #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Oct 17, 2023

Changes

JWT mismatched claims errors are only happening for dev and staging deployments of Databricks, adding the unnecessary noise to production users. azure_workspace_resource_id is not required for authentication to succeed.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

… for non-production Databricks deployments

JWT mismatched claims errors are only happening for dev and staging deployments of Databricks, adding the unnecessary noise to production users. `azure_workspace_resource_id` is not required for authentication to succeed.
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
databricks/sdk/core.py 80.40% <0.00%> (-0.09%) ⬇️

📢 Thoughts on this report? Let us know!.

@hectorcast-db
Copy link
Contributor

This can also happen if the user has multiple tenants setup in their azure cli. Miles deduplicated the warning message in here:
https://github.com/databricks/databricks-sdk-py/pull/410/files

@mgyucht
Copy link
Contributor

mgyucht commented Oct 24, 2023

This warning message is intentional and is designed to help out users who haven't specified the azure resource ID for workspace they are logging into when using Azure CLI auth. If you specify the azure resource ID in your configuration, that warning message will disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] azure_workspace_resource_id is displayed when using Azure CLI auth
5 participants