preserve directories in recursive workspace listing #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Best <60439766+neilbest-db@users.noreply.github.com>
Signed-off-by: Neil Best <60439766+neilbest-db@users.noreply.github.com>
neilbest-db
force-pushed
the
fix/465-recursive-workspace-listing
branch
from
7734cf5
to
608b644
Compare
…com/neilbest-db/databricks-sdk-py into fix/465-recursive-workspace-listing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 51.57% 51.57%
=======================================
Files 38 38
Lines 22355 22354 -1
=======================================
Hits 11530 11530
+ Misses 10825 10824 -1 ☔ View full report in Codecov by Sentry. |
nfx
requested changes
Dec 23, 2023
| @@ -32,7 +32,6 @@ def list(self, | |||
| for object_info in parent_list(path, notebooks_modified_after=notebooks_modified_after): | |||
| if recursive and object_info.object_type == ObjectType.DIRECTORY: | |||
| queue.append(object_info.path) | |||
| continue | |||
There was a problem hiding this comment.
this breaks established behavior, that thousands of projects depend on. Add an optional keyword argument disabled by default if you want this change
| @@ -5,9 +5,17 @@ | |||
|
|
|||
| def test_workspace_recursive_list(w, random): | |||
There was a problem hiding this comment.
existing unit tests must be left unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallymake fmtapplied