Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution examples, run fmte #491

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Weilando
Copy link

Changes

We fix broken examples with old command or statement execution calls. In addition, we run make fmte.

Closes #341
Closes #267

Tests

We have fixed function calls in the examples. Therefore, production code is not affected.

  • make test run locally
  • make fmt applied (also make fmte)
  • relevant integration tests applied

@mgyucht
Copy link
Contributor

mgyucht commented Jan 3, 2024

@Weilando thank you for contributing this. FYI: only the top-level examples are maintained by hand; the rest are autogenerated, so your changes will be overwritten by the next autogeneration run. We need to fix those examples separately. Can you remove the changes to autogenerated examples?

Also, please make sure your commits are signed, otherwise we can't merge them.

@Weilando
Copy link
Author

Weilando commented Jan 3, 2024

Thanks for the hint, @mgyucht! So we only need to change examples/flask_app_with_oauth.py and examples/starting_job_and_waiting.py manually, correct? How do we update the autogenerated examples?

Sorry, I was not aware of signed commits so far and will make sure to set it up accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants