Lakehouse monitoring integration #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpitjasa-db
reviewed
May 3, 2024
There was a problem hiding this comment.
Some initial comments, but thanks for doing this @s-udhaya !
...t_root_dir}}/{{template `project_name_alphanumeric_underscore` .}}/monitoring/README.md.tmpl
Outdated
Show resolved
Hide resolved
...t_root_dir}}/{{template `project_name_alphanumeric_underscore` .}}/monitoring/README.md.tmpl
Outdated
Show resolved
Hide resolved
...{{template `project_name_alphanumeric_underscore` .}}/resources/monitoring-resource.yml.tmpl
Outdated
Show resolved
Hide resolved
...{{template `project_name_alphanumeric_underscore` .}}/resources/monitoring-resource.yml.tmpl
Outdated
Show resolved
Hide resolved
...e `project_name_alphanumeric_underscore` .}}/monitoring/metric_violation_check_query.py.tmpl
Outdated
Show resolved
Hide resolved
arpitjasa-db
reviewed
May 7, 2024
...e `project_name_alphanumeric_underscore` .}}/resources/monitoring-workflow-resource.yml.tmpl
Outdated
Show resolved
Hide resolved
arpitjasa-db
reviewed
May 7, 2024
| @@ -143,6 +143,41 @@ Model validation contains three components: | |||
| To set up and enable model validation, update [validation.py](../validation/validation.py) to return desired custom metrics and validation thresholds, then | |||
| resolve the `TODOs` in the ModelValidation task of [model-workflow-resource.yml](./model-workflow-resource.yml). | |||
|
|
|||
|
|
|||
| ### Setting up model monitoring | |||
There was a problem hiding this comment.
Suggested change
| ### Setting up model monitoring | |
| ### Setting up Lakehouse monitoring |
Change elsewhere too please to match our branding
There was a problem hiding this comment.
I understand we are still discussing on this internally. I will update this when we finalize the unified naming convention
- Minor readme changes - Use dafault assets_dir path for monitoring
s-udhaya
force-pushed
the
lakehouse-monitoring-integration
branch
5 times, most recently
from
ff13cdd
to
37bf41b
Compare
- Accept inference table name from CLI - Merge monitoring related resources into a single file - Parametrize the metric and validation threshold
s-udhaya
force-pushed
the
lakehouse-monitoring-integration
branch
from
37bf41b
to
a7c882b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates lakehouse monitoring, with automatic retraining component into mlops-stack.